This repository was archived by the owner on Nov 15, 2023. It is now read-only.
use clap3 instead of structopt#10632
Merged
paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom Jan 24, 2022
koushiro:use-clap3
Merged
use clap3 instead of structopt#10632paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom koushiro:use-clap3
paritytech-processbot[bot] merged 14 commits intoparitytech:masterfrom
koushiro:use-clap3
Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
bkchr
reviewed
Jan 11, 2022
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Ty for doing this. I just skimmed it, but it looks good!
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
bkchr
approved these changes
Jan 17, 2022
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Ty!
The amount of changes looks big, but as we already touch all these lines or most of them we can directly simplify all the code.
And also, please stop using force pushes.
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
| case_insensitive = true, | ||
| possible_values = &Database::variants(), | ||
| ignore_case = true, | ||
| possible_values = Database::variants(), |
Contributor
There was a problem hiding this comment.
No replacement to arg_enum here?
Contributor
Author
There was a problem hiding this comment.
if I use arg_enum here, do I need to remove the variants method of Database and impl std::str::FromStr for Database?
Contributor
There was a problem hiding this comment.
I have no idea what that means, I'm just pointing out how it looks different from the other enums where you put arg_num.
Contributor
Author
There was a problem hiding this comment.
Because the variants method of other enums are generated by structopt, but the Database::variants and WasmExecutionMethod::variants are implemented manually.
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
KiChjang
reviewed
Jan 17, 2022
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Member
|
@koushiro CI is still not happy. |
bkchr
added
A0-please_review
Member
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 38f7b7c |
Contributor
Author
|
@bkchr could you merge this PR? I don't want to resolve the conflicts again :( |
KiChjang
approved these changes
Jan 24, 2022
Contributor
|
bot merge |
Member
|
/tip small |
|
A small tip was successfully submitted for koushiro (15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK on polkadot). |
eskimor
pushed a commit
that referenced
this pull request
Jan 27, 2022
* use clap3 instead of structopt Signed-off-by: koushiro <koushiro.cqx@gmail.com> * format Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update ss58-registry and revert some nits Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Fix clippy and doc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update clap to 3.0.7 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Apply review suggestions Signed-off-by: koushiro <koushiro.cqx@gmail.com> * remove useless option long name Signed-off-by: koushiro <koushiro.cqx@gmail.com> * cargo fmt Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* use clap3 instead of structopt Signed-off-by: koushiro <koushiro.cqx@gmail.com> * format Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update ss58-registry and revert some nits Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Fix clippy and doc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update clap to 3.0.7 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Apply review suggestions Signed-off-by: koushiro <koushiro.cqx@gmail.com> * remove useless option long name Signed-off-by: koushiro <koushiro.cqx@gmail.com> * cargo fmt Signed-off-by: koushiro <koushiro.cqx@gmail.com>
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 25, 2022
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 28, 2022
* chore: bump deps to Polkadot v0.9.17 * fix: rm Default requirement for AccountId types * fix: use clap3 instead of structop paritytech/substrate#10632 * fix: AccountId doesnt impl Default anymore * chore: bump deps * chore: bump clap * fix: clippy * fix: EnsureDidOrigin * fix: remove unwanted dependency leftover
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* use clap3 instead of structopt Signed-off-by: koushiro <koushiro.cqx@gmail.com> * format Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update ss58-registry and revert some nits Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Fix clippy and doc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update clap to 3.0.7 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Apply review suggestions Signed-off-by: koushiro <koushiro.cqx@gmail.com> * remove useless option long name Signed-off-by: koushiro <koushiro.cqx@gmail.com> * cargo fmt Signed-off-by: koushiro <koushiro.cqx@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* use clap3 instead of structopt Signed-off-by: koushiro <koushiro.cqx@gmail.com> * format Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update ss58-registry and revert some nits Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Fix clippy and doc Signed-off-by: koushiro <koushiro.cqx@gmail.com> * update clap to 3.0.7 Signed-off-by: koushiro <koushiro.cqx@gmail.com> * Apply review suggestions Signed-off-by: koushiro <koushiro.cqx@gmail.com> * remove useless option long name Signed-off-by: koushiro <koushiro.cqx@gmail.com> * cargo fmt Signed-off-by: koushiro <koushiro.cqx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
use
clapv3 instead ofstructopt(Close #10651)waiting for a new version (includes the paritytech/ss58-registry#67) ofss58-registryto be released firstlypolkadot companion: paritytech/polkadot#4689
cumulus companion: paritytech/cumulus#895
Polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK